Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added pagination for endpoint that return answers for loris (M2-7656) #1571

Open
wants to merge 1 commit into
base: loris-integration-phase-2
Choose a base branch
from

Conversation

ZenaY91
Copy link
Contributor

@ZenaY91 ZenaY91 commented Aug 27, 2024

Added pagination functionality

🔗 Jira Ticket M2-7656

@ZenaY91 ZenaY91 requested a review from vshvechko August 27, 2024 12:43
Copy link

➡️ Preview environment created: Click Me!

Copy link

❌ E2E tests failed

Copy link
Contributor

@vshvechko vshvechko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That doesn’t seem sufficient. If the user has already submitted the first page of answers, they might reload the page and see an empty one because all the answers retrieved from the database are filtered out when compared to those already pushed to Loris.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants